Editing pass for the migration guide #1499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 2, 2024 15:30
It didn't exist!
alice-i-cecile
added
A-Migration Guides
C-Correction
BD103
approved these changes
Jul 2, 2024
| @@ -77,7 +77,7 @@ areas = ["Assets"] | |||
| file_name = "12605_Make_AssetActionIgnore_not_copy_assets_to_imported_assets.md" | |||
|
|
|||
| [[guides]] | |||
| title = "Removed `Into<AssedId<T>>` for `Handle<T>`" | |||
| title = "Removed `Into<AssetId<T>>` for `Handle<T>`" | |||
There was a problem hiding this comment.
I'm confused why this shows up in the diff, since there's not visible changes. Is this a unicode thing?
release-content/0.14/migration-guides/12551_Remove_WorldCell.md
Outdated
Show resolved
Hide resolved
release-content/0.14/migration-guides/12314_Clean_up_type_registrations.md
Outdated
Show resolved
Hide resolved
BD103
added
the
S-Ready-For-Final-Review
Co-authored-by: BD103 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on @BD103's excellent work refining these, and closes #1396.
A few small corrections, and I've moved the most vital breaking changes to the top for prominence.
We could go further, but I'm very happy with the state of this as it is now.