Skip to content

add aria-label to image compare slider #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2024

Conversation

SIGSTACKFAULT
Copy link
Contributor

a whopping one line of code to make #1046 happy.

image

@SIGSTACKFAULT
Copy link
Contributor Author

I cherry-picked this onto 1046 and ran act and it seems to have passed. but i don't exactly grok github ci.

@TrialDragon TrialDragon added C-Feature A new feature, making something new possible C-Accessibility S-Ready-For-Final-Review Ready for a maintainer to consider for merging C-Webdev labels May 6, 2024
Copy link
Member

@TrialDragon TrialDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested it with Pa11y and this solves the issue. Thanks for implementing this.

@cart cart added this pull request to the merge queue May 7, 2024
Merged via the queue into bevyengine:main with commit aeda505 May 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Accessibility C-Feature A new feature, making something new possible C-Webdev S-Ready-For-Final-Review Ready for a maintainer to consider for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants