-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
Would be even nicer now that you made grpclib optional. |
4e32767
to
27e63fa
Compare
Sorry, I missed your comment. Yes, I plan to make Thank you for your interest! I think it will take me a few months before the first stable release (I hope it will be less, but it will depend on how the development goes). I want to avoid breaking changes after this release, so I'd like to make sure everything is fine before doing so. After that, yes, I plan to keep maintaining the library. |
0aba274
to
1c5a909
Compare
1c5a909
to
656585d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds synchronous stub support by introducing a new client generation option throughout the codebase. Key changes include updating the protoc command options in tests, adding a ClientGeneration enum with new properties in the settings, and updating the plugin parser to handle the new client_generation option.
Reviewed Changes
Copilot reviewed 6 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
tests/util.py | Inserts new command-line options for client_generation in protoc invocation. |
tests/inputs/simple_service/simple_service.proto | Adds a basic proto file for testing the new client generation functionality. |
src/betterproto2_compiler/settings.py | Introduces a ClientGeneration enum and adds a client_generation field to the Settings dataclass. |
src/betterproto2_compiler/plugin/parser.py | Updates get_settings to parse client_generation options and return a Settings instance accordingly. |
pyproject.toml | Updates dependency definitions to include grpc-async extras and adds the strenum dependency. |
Files not reviewed (5)
- src/betterproto2_compiler/templates/header.py.j2: Language not supported
- src/betterproto2_compiler/templates/service_stub.py.j2: Language not supported
- src/betterproto2_compiler/templates/service_stub_async.py.j2: Language not supported
- src/betterproto2_compiler/templates/service_stub_sync.py.j2: Language not supported
- src/betterproto2_compiler/templates/template.py.j2: Language not supported
Adapted from danielgtaylor/python-betterproto#647