Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node.js #673

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Update Node.js #673

merged 1 commit into from
Dec 4, 2023

Conversation

haslinghuis
Copy link
Member

image

image

@haslinghuis haslinghuis self-assigned this Dec 2, 2023
@haslinghuis haslinghuis added the dependencies Pull requests that update a dependency file label Dec 2, 2023
@haslinghuis haslinghuis added this to the 3.7.0 milestone Dec 2, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-Linux
Betaflight-Blackbox-Explorer-macOS
Betaflight-Blackbox-Explorer-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Dec 2, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

nerdCopter
nerdCopter approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • tested good on Debian 11 Linux

McGiverGim
McGiverGim approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start again with the versions game 😉

@haslinghuis haslinghuis merged commit 2e2d887 into betaflight:master Dec 4, 2023
@haslinghuis haslinghuis deleted the update-nodejs branch December 4, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@chmelevskij chmelevskij Awaiting requested review from chmelevskij

Assignees

@haslinghuis haslinghuis

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@haslinghuis @blckmn @McGiverGim @nerdCopter