Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip vtx tables download if not available #475

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

klutvott123
Copy link
Member

@klutvott123 klutvott123 commented Mar 12, 2023

Use msp error bit to determine if message is available in firmware or not. Pass msp error to the layer above so that we can take action if there's an error.
The FC will still respond if for example MSP_VTX_CONFIG isn't available, but the msp over telemetry error bit will be set and the payload is an error code. We can use this to detect if the firmware has been compiled with VTX support, and skip vtx tables download if not.

Fixes #474

betaflight-tx-lua-scripts_1.7.0.zip

@klutvott123 klutvott123 added this to the 1.8 milestone Mar 12, 2023
@klutvott123 klutvott123 self-assigned this Mar 12, 2023
@klutvott123
Copy link
Member Author

Added the message "N/A" that will replace the content of the page if it can't be loaded. Updated first post with new zip file if anyone wants to try it.

@TheIsotopes
Copy link

@klutvott123
for the osd elements page there should also be a query as to whether the firmware was compiled with osd.
lua scripts must be ended with long RTN because an error message appears.

@klutvott123
Copy link
Member Author

Where exactly does this error message appear? And what does it say?

MSP_OSD_CONFIG isn't wrapped in "#IF defined(USE_OSD) like it should have been, so it will return something even if the firmware is compiled without OSD. This means we can't detect it in the same way as for vtx and gps rescue for example. The way it's done in the firmware is very inconsistent between messages. it's annoying and we should look into it

@TheIsotopes
Copy link

here the sreenshot from error:

screen-2023-03-12-230014

@klutvott123
Copy link
Member Author

@TheIsotopes And this is without OSD, OSD_SD and OSD_HD?

@TheIsotopes
Copy link

yes, here the build log:
https://build.betaflight.com/api/builds/4d670535f2542931175af51bc9078de1/log

@klutvott123
Copy link
Member Author

Thanks! will look into it.

haslinghuis
haslinghuis previously approved these changes Mar 13, 2023
@TomAlperin
Copy link

Tested and working properly although I did notice that for analog, the second load is a little bit faster. Tested with my previous work around of creating the files manually and that prevents the VTX table check making the load time a bit faster for digital video systems.

@klutvott123
Copy link
Member Author

@TomAlperin Thanks for testing. I made it so that it creates a empty vtx table if not available. This will make it skip future download attempts
betaflight-tx-lua-scripts_1.7.0.zip

@klutvott123
Copy link
Member Author

@TheIsotopes Can you try this? betaflight/betaflight#12513

@haslinghuis haslinghuis merged commit d900131 into betaflight:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

Waiting for VTX Tables
4 participants