-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip vtx tables download if not available #475
Conversation
Added the message "N/A" that will replace the content of the page if it can't be loaded. Updated first post with new zip file if anyone wants to try it. |
@klutvott123 |
Where exactly does this error message appear? And what does it say? MSP_OSD_CONFIG isn't wrapped in |
@TheIsotopes And this is without OSD, OSD_SD and OSD_HD? |
yes, here the build log: |
Thanks! will look into it. |
Tested and working properly although I did notice that for analog, the second load is a little bit faster. Tested with my previous work around of creating the files manually and that prevents the VTX table check making the load time a bit faster for digital video systems. |
@TomAlperin Thanks for testing. I made it so that it creates a empty vtx table if not available. This will make it skip future download attempts |
@TheIsotopes Can you try this? betaflight/betaflight#12513 |
Use msp error bit to determine if message is available in firmware or not. Pass msp error to the layer above so that we can take action if there's an error.
The FC will still respond if for example MSP_VTX_CONFIG isn't available, but the msp over telemetry error bit will be set and the payload is an error code. We can use this to detect if the firmware has been compiled with VTX support, and skip vtx tables download if not.
Fixes #474
betaflight-tx-lua-scripts_1.7.0.zip