Skip to content

Fix CHIRP is absent in build options list #4527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mituritsyn
Copy link
Contributor

@mituritsyn mituritsyn commented Jun 20, 2025

configurator part for betaflight/betaflight#14468

Summary by CodeRabbit

  • New Features
    • Added a new firmware build option labeled "USE_CHIRP" to the available build options.

Copy link
Contributor

coderabbitai bot commented Jun 20, 2025

Walkthrough

A new firmware build option, USE_CHIRP, with a value of 16426, was added to the FIRMWARE_BUILD_OPTIONS constant in the codebase. No other logic or code was changed.

Changes

File(s) Change Summary
src/js/fc.js Added USE_CHIRP: 16426 to FIRMWARE_BUILD_OPTIONS constant

Suggested labels

RN: IMPROVEMENT

Suggested reviewers

  • nerdCopter
  • VitroidFPV

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3052b32 and 7543dd9.

📒 Files selected for processing (1)
  • src/js/fc.js (1 hunks)
🔇 Additional comments (1)
src/js/fc.js (1)

127-129: Approve inclusion of the CHIRP build option.
The new entry USE_CHIRP: 16426 correctly follows the existing sequence in FIRMWARE_BUILD_OPTIONS and aligns with the Betaflight core PR. Ensure that this numeric ID exactly matches the definition in the core repository so that CHIRP appears in the UI as intended.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Copy link
Contributor

Preview URL: https://7543dd9c.betaflight-configurator.pages.dev

@mituritsyn mituritsyn marked this pull request as ready for review June 20, 2025 21:48
@mituritsyn
Copy link
Contributor Author

@haslinghuis is cloudbuild api closed source and this should be fixed by core members?

@haslinghuis
Copy link
Member

Yes @blckmn has to add it to cloud API

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving, but i did not check sort-order

Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this can be merged the option needs to be added to cloud API first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants