Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with Odd-Order Highpass Filters #27

Closed
anleu opened this issue Oct 5, 2023 · 2 comments
Closed

Issue with Odd-Order Highpass Filters #27

anleu opened this issue Oct 5, 2023 · 2 comments

Comments

@anleu
Copy link

anleu commented Oct 5, 2023

After introducing new tests, it was observed that highpass filters of odd order produce incorrect results. This issue has already been reported in the original library, as seen in this issue.

The proposed fix appears to be effective. Both tbrunsch and I have tested the fix, and it seems to work without introducing any other issues. Additionally, upon reviewing the code, we've verified that the changes exclusively affect the highpass filter and do so correctly.

We will be submitting a PR that includes both the unit tests and the fix for this problem.
This was referenced Oct 5, 2023
Closed
Merged
anleu pushed a commit to anleu/iirj that referenced this issue Oct 5, 2023
fix Bug in Biquad assignment
54e8e38 
add UnitTest to compare IIRJ results with given Scipy results

relates to berndporr#27

add UnitTest to compare IIRJ results with given Scipy results
fix Bug in Biquad assignment
@berndporr
Copy link
Owner

id-0001
thanks. Indeed. Pole and zero should end up in the same coefficient as the math is the same of both numerator and denominator.

berndporr added a commit to berndporr/iir1 that referenced this issue Oct 5, 2023
@berndporr
Single Pole/Zero bugfix
379d697 
This fixes a bug reported already in the original DSPFilters:
vinniefalco/DSPFilters#29 and
confirmed for the JAVA port berndporr/iirj#27.
That's now fixed.
@anleu
Copy link
Author

anleu commented Oct 10, 2023

Bug is fixed with commit 54e8e38.

@anleu anleu closed this as completed Oct 10, 2023
myd7349 added a commit to myd7349/brainflow that referenced this issue Jan 7, 2024
@myd7349
fix phase inversion of odd order high pass filters
acc55d6 
This is a known bug of DSPFilters:

vinniefalco/DSPFilters#29

and has been fixed in iir1 and iirj:

berndporr/iir1@379d697

berndporr/iirj#27
myd7349 added a commit to myd7349/brainflow that referenced this issue Jan 7, 2024
@myd7349
fix phase inversion of odd order high pass filters
4dd9519 
This is a known bug of DSPFilters:
vinniefalco/DSPFilters#29
and has been fixed in iir1 and iirj:
berndporr/iir1@379d697
berndporr/iirj#27
myd7349 added a commit to myd7349/brainflow that referenced this issue Jan 7, 2024
@myd7349
fix phase inversion of odd order high pass filters
f444035 
This is a known issue with DSPFilters:
vinniefalco/DSPFilters#29
and has been fixed in iir1 and iirj:
berndporr/iir1@379d697
berndporr/iirj#27
@myd7349 myd7349 mentioned this issue Jan 7, 2024
Merged
Andrey1994 pushed a commit to brainflow-dev/brainflow that referenced this issue Jan 7, 2024
@myd7349
fix phase inversion of odd order high pass filters (#693)
4b494e2 
This is a known issue with DSPFilters:
vinniefalco/DSPFilters#29
and has been fixed in iir1 and iirj:
berndporr/iir1@379d697
berndporr/iirj#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@berndporr @anleu