Skip to content

Add possibility to show resetbutton for readonly fields #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add possibility to show resetbutton for readonly fields #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion resetbutton-vaadin8-addon/src/main/java/org/vaadin/addons/ResetButtonForTextField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@
import com.vaadin.server.AbstractClientConnector;
import com.vaadin.server.AbstractExtension;
import com.vaadin.shared.Registration;
import com.vaadin.shared.communication.SharedState;
import com.vaadin.ui.TextField;

import org.vaadin.addons.client.ResetButtonClickRpc;
import org.vaadin.addons.client.ResetButtonForTextFieldState;

import java.util.ArrayList;
import java.util.List;
Expand Down Expand Up @@ -33,4 +35,17 @@ public Registration addResetButtonClickedListener(ResetButtonClickListener liste

return () -> listeners.remove(listener);
}
}

@Override
protected ResetButtonForTextFieldState getState() {
return (ResetButtonForTextFieldState) super.getState();
}

public void setShowForReadOnly(boolean pValue) {
getState().showForReadOnly = pValue;
}

public boolean isShowForReadOnly() {
return getState().showForReadOnly;
}
}
8 changes: 7 additions & 1 deletion ...aadin8-addon/src/main/java/org/vaadin/addons/client/ResetButtonForTextFieldConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import com.vaadin.client.communication.StateChangeEvent;
import com.vaadin.client.extensions.AbstractExtensionConnector;
import com.vaadin.client.ui.VTextField;
import com.vaadin.shared.communication.SharedState;
import com.vaadin.shared.ui.Connect;

import org.vaadin.addons.ResetButtonForTextField;
Expand Down Expand Up @@ -93,7 +94,7 @@ public void onKeyUp(KeyUpEvent event) {
}

private void updateResetButtonVisibility() {
if (textField.getValue().isEmpty() || textField.isReadOnly()
if (textField.getValue().isEmpty() || (!getState().showForReadOnly && textField.isReadOnly())
|| !textField.isEnabled()
|| textField.getStyleName().contains("v-textfield-prompt")) {
resetButtonElement.getStyle().setDisplay(Display.NONE);
Expand All @@ -107,4 +108,9 @@ private void clearTextField() {
updateResetButtonVisibility();
textField.getElement().focus();
}

@Override
public ResetButtonForTextFieldState getState() {
return (ResetButtonForTextFieldState) super.getState();
}
}
7 changes: 7 additions & 0 deletions ...on-vaadin8-addon/src/main/java/org/vaadin/addons/client/ResetButtonForTextFieldState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package org.vaadin.addons.client;

import com.vaadin.shared.communication.SharedState;

public class ResetButtonForTextFieldState extends SharedState{
public boolean showForReadOnly = false;
}