fix(sdk/cli): Correct HuggingFace model copy #5355
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
2 things, mainly:
models/huggingface.py
:HuggingFaceModel.resolve
where the incorrect source directory (grandparent of the snapshot) was being copied when abase_path
was provided. I believe this leads to large/incorrect copies. The fix ensures only the specific model snapshot is copied to a correctly named subdirectory within thebase_path
service/factory.py
:AttributeError
in the deprecatedrunner_service
function by initializingconfig["workers"]
as a list ([]
) instead of a dictionary ({}
) 👍cli/deployment.py
:@click.option
definition for--config-file
(it's right above the deleted one 👍 )Before submitting:
guide on how to create a pull request.
pre-commit run -a
script has passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.