This repository was archived by the owner on Jul 13, 2020. It is now read-only.
WIP: override-major-mode-keybindings #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use-jupyter-eval-pop function for cleaner keybindings where the focus goes to the repl buffer.
|
So far it's working on 2 machines. |
benneti
reviewed
Oct 1, 2019
| (defvar use-jupyter-repl-mode nil) | ||
| ;; (defvar use-jupyter-repl-mode nil) | ||
|
|
||
| (define-minor-mode use-jupyter-repl-mode |
There was a problem hiding this comment.
I think this should be a local package, i.e. a file and then loaded in packages.el, this might also fix needing to use the keybinging twice
There was a problem hiding this comment.
The file should be in a subfolder local (see for example the +completion/helm layer with helm-spacemacs-help
| '( | ||
| company | ||
| jupyter | ||
| smartparens |
There was a problem hiding this comment.
i.e. added here and then have an init-use-jupyter-repl...
There was a problem hiding this comment.
like this (use-jupyter... :location local)
vv111y
force-pushed
the
override-major-keybindings
branch
from
98ba535 to
d38864e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any major-mode, provide the option to override spacemacs repl related keybindings so that a jupyter repl is used instead.
SPC a j tChecks for kernel. Callsjupyter-repl-associate-bufferif there is no kernel for the buffer. I think check makes most sense here.Using spacemacs code as a guide:
use-package:init