deduplicate workspace package names #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, @OmarTawfik for pointing this out! This seems to be a false positive. The In the meantime, the suggested workaround seems to be setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the recommended way to install
bencher_clifrom source produces the following warnings:$ cargo install bencher_cli --git https://github.com/bencherdev/bencher --branch main Updating git repository `https://github.com/bencherdev/bencher` warning: skipping duplicate package `game` found at `/.../rust/git/checkouts/bencher-c9d027409129568d/6b48e62/examples/rust/iai` warning: skipping duplicate package `game` found at `/.../rust/git/checkouts/bencher-c9d027409129568d/6b48e62/examples/rust/criterion` warning: skipping duplicate package `xtask` found at `/.../rust/git/checkouts/bencher-c9d027409129568d/6b48e62/examples/ebpf/xdp/xtask`This deduplicates the different package names in the workspace by adding parent-specific prefixes.