Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beman.execution26: change library status to under development #104

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

RaduNichita
Copy link
Contributor

@RaduNichita RaduNichita commented Dec 21, 2024

Issues: bemanproject/beman#77

Expected README.md:

image

Copy link
Member

@neatudarius neatudarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the API is stable (it's in the Draft). I ask @dietmarkuehl to confirm if the library is also production ready.

Thanks!

CC: @bemanproject/leads

README.md Outdated
**Implements:** [`std::execution` (P2300)](http://wg21.link/p2300).
**Implements:** [`std::execution` (P2300R10)](http://wg21.link/P2300R10).

**Status**: [Production ready. Stable API.](https://github.com/bemanproject/beman/blob/main/docs/BEMAN_LIBRARY_MATURITY_MODEL.md#production-ready-stable-api)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced that is the correct status: there are few bits missing from P2300 which still need to be implemented. There are also a number of things tagged "TODO" in the code which should be addressed in some form.

Copy link
Member

@neatudarius neatudarius Dec 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this is why we explicitly asked you. What do you recommend? (Please check BEMAN_LIBRARY_MATURITY_MODEL.md)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the Beman Library Maturity Model the implementation is "under development": while the API is approved and merged into the working paper, the implementation isn't complete covering all of the API. Also, the API isn't standardised, yet, an possibly subject to change.

One interesting side question is: the repo currently contains [partial] implementations of multiple papers:

There are also a few additional papers in the space which fit the theme of this project:

For some of these proposal it doesn't make any sense to got into a separate Beman project as the inherently change how things are implemented. Others are add-ons which may get into the same header. Creating them in a separate Beman project would, at minimum require some approach to reconcile how they are used. Some are just add-ons and could get into a separate Beman project requiring separate infrastructure and creating a more awkward user experience. Which raises a few questions:

  1. Should things be factored into different Beman projects if it is possible?
  2. For things within one project, the proposals may be in different state for readiness: should they have separate maturity indicators?

I guess, that may be a discussion for Discourse and I'll post the question there.

Copy link
Collaborator

@dietmarkuehl dietmarkuehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The status needs to be adjusted: the library is currently still under development

@RaduNichita RaduNichita changed the title beman.execution26: change library status to production-ready stable api beman.execution26: change library status to under development Dec 22, 2024
@dietmarkuehl dietmarkuehl merged commit 2d7e75e into bemanproject:main Dec 22, 2024
1 check passed
dietmarkuehl pushed a commit that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants