Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the Beman Library Maturity Model #72

Merged

Conversation

neatudarius
Copy link
Member

@neatudarius neatudarius commented Dec 4, 2024

Update Beman Standard: add README.LIBRARY_STATUS - #77

As discussed in multiple syncs , we need to introduce a new document. The current proposal is to add BEMAN_PROCESS.md and link it with the BEMAN_STANDARD.md.

Updates:

  • Create BEMAN_LIBRAY_MATURITY_MODEL.md. Applied suggestions for 5 status values and their description from our last sync.
  • Add README.LIBRARY_STATUS into the Beman Standard.
  • Create images/ where to store all images. e.g. images/logos and others.

Copy link

@RaduNichita RaduNichita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a first pass on the documents, looks good

docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_STANDARD.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
Copy link

@RaduNichita RaduNichita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, left a few more comments. Thanks @neatudarius

README.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_STANDARD.md Outdated Show resolved Hide resolved
docs/BEMAN_STANDARD.md Outdated Show resolved Hide resolved
docs/BEMAN_STANDARD.md Outdated Show resolved Hide resolved
@neatudarius
Copy link
Member Author

neatudarius commented Dec 4, 2024

@RaduNichita , please take another look.

docs/BEMAN_STANDARD.md Outdated Show resolved Hide resolved
docs/BEMAN_STANDARD.md Outdated Show resolved Hide resolved
docs/BEMAN_STANDARD.md Outdated Show resolved Hide resolved
@RaduNichita RaduNichita self-requested a review December 5, 2024 07:30
Copy link

@RaduNichita RaduNichita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

@RaduNichita RaduNichita self-requested a review December 5, 2024 07:38
@neatudarius neatudarius force-pushed the BEMAN_STANDARD/add-LIBRARY_STATUS branch 2 times, most recently from 6332891 to 83d5ac8 Compare December 5, 2024 07:57
@neatudarius neatudarius changed the title Update Beman Standard: add README.LIBRARY_STATUS Update Beman Standard: add README.LIBRARY_STATUS; Create Beman Process Dec 5, 2024
Copy link
Member

@camio camio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added several comments to this PR. The most important is on the phase names. I think using descriptive names instead of introducing special parlance (like BEMAN DEVELOPMENT) will make it easier for readers to understand the status.

Here is what I suggested:

Before After
BEMAN DEVELOPMENT Under development and not yet ready for production use.
BEMAN UNSTABLE Production ready. API may undergo changes.
BEMAN STABLE Production ready. Stable API.

It also solves the problem that "unstable" has a negative connotation without additional context.

docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
docs/BEMAN_STANDARD.md Outdated Show resolved Hide resolved
docs/BEMAN_STANDARD.md Outdated Show resolved Hide resolved
docs/BEMAN_STANDARD.md Outdated Show resolved Hide resolved
docs/BEMAN_STANDARD.md Outdated Show resolved Hide resolved
docs/BEMAN_STANDARD.md Outdated Show resolved Hide resolved
docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bretbrownjr bretbrownjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in support of the work Darius is doing here.

I would mark this "Approved", but a bunch of us Beman contributors discussed this PR just now in the weekly meeting. The feeling in the room was that breaking the document up into separate parts would be great. In particular:

  • Conceptual docs about the Beman maturity model that are intended for users of Beman libraries
  • One or more how-to guides intended for Beman contributors

docs/BEMAN_PROCESS.md Outdated Show resolved Hide resolved
@neatudarius neatudarius force-pushed the BEMAN_STANDARD/add-LIBRARY_STATUS branch 2 times, most recently from 65df1e5 to fb3a595 Compare December 12, 2024 00:45
@neatudarius neatudarius changed the title Update Beman Standard: add README.LIBRARY_STATUS; Create Beman Process Update Beman Standard: add README.LIBRARY_STATUS; Add BEMAN_LIBRAY_MATURITY_MODEL.md Dec 12, 2024
@neatudarius neatudarius force-pushed the BEMAN_STANDARD/add-LIBRARY_STATUS branch from fb3a595 to f5eedad Compare December 12, 2024 00:51
@neatudarius
Copy link
Member Author

neatudarius commented Dec 12, 2024

@bemanproject/leads @camio @inbal2l @RaduNichita , pushed a completely new version of this PR.
Please redo the review, I tried to incorporate all comments.

For the new file, please use the View file button if images are not displayed in diff preview mode (only full view mode works for me!)

Expected visual effect:
image

Example of expected usage in other repos: bemanproject/dump#6
image

@neatudarius neatudarius force-pushed the BEMAN_STANDARD/add-LIBRARY_STATUS branch 2 times, most recently from 3e7c993 to 5a6cab8 Compare December 12, 2024 01:16
Copy link

@RaduNichita RaduNichita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we generate logos as svg files?

docs/BEMAN_LIBRAY_MATURITY_MODEL.md Outdated Show resolved Hide resolved
docs/BEMAN_STANDARD.md Outdated Show resolved Hide resolved
docs/BEMAN_STANDARD.md Outdated Show resolved Hide resolved
presentations/beman_overview_wg21_202406.org Show resolved Hide resolved
docs/BEMAN_STANDARD.md Outdated Show resolved Hide resolved
docs/BEMAN_STANDARD.md Outdated Show resolved Hide resolved
docs/BEMAN_LIBRAY_MATURITY_MODEL.md Outdated Show resolved Hide resolved
docs/BEMAN_LIBRAY_MATURITY_MODEL.md Outdated Show resolved Hide resolved
docs/BEMAN_LIBRAY_MATURITY_MODEL.md Outdated Show resolved Hide resolved
docs/BEMAN_LIBRAY_MATURITY_MODEL.md Outdated Show resolved Hide resolved
docs/BEMAN_LIBRAY_MATURITY_MODEL.md Outdated Show resolved Hide resolved
docs/BEMAN_STANDARD.md Outdated Show resolved Hide resolved
@neatudarius neatudarius force-pushed the BEMAN_STANDARD/add-LIBRARY_STATUS branch from 1431be5 to 67b8322 Compare December 18, 2024 16:08
@neatudarius neatudarius changed the title Update Beman Standard: add README.LIBRARY_STATUS; Add BEMAN_LIBRAY_MATURITY_MODEL.md Create the Beman Library Maturity Model Dec 18, 2024
@neatudarius neatudarius force-pushed the BEMAN_STANDARD/add-LIBRARY_STATUS branch from df7cac7 to b3655c4 Compare December 18, 2024 18:49
@neatudarius
Copy link
Member Author

neatudarius commented Dec 18, 2024

I think we have enough information and replies (#72 (comment) and #72 (comment)) to conclude that at least the topic of adding an extra state for Beman libraries is controversial.

  • @inbal2l has valid concerns about some usecases which may be clarified.
  • @camio also has valid concerns about other usecases that are not included by adding a new state.
    Probably, on a long-term approach we need to rediscuss this topic in a sync. I know we briefly discussed 2 weeks ago, but it seems to not be enough.

===============================================

My personal conclusion is that right now there is NO benefit from adding a new state. There is no obvious perfect solution, so just using Retired is good enough. I think we had enough discussions about details on this PR and we don't have a concrete progress related to actually put "labels" on our libraries (and the website).

===============================================

I would strongly suggest to move forward with an initial version as we don't actually have a need right now to possible distinguish between these cases. My proposal is to split this machinery into versions:

Anybody can try to propose an extension later. I would really want to be able to use this framework EOY, please!

CC: @bemanproject/leads @inbal2l @camio @RaduNichita

@RaduNichita
Copy link

LGTM, thanks Darius!

@JeffGarland
Copy link
Member

I'm coming in late here, but wow this looks really great to me -- especially using the logos!

I didn't read the whole history, but one thing I'll just mention that we might want to express somewhere is that retired really means it's been removed from the main distribution. The author might actually still be supporting -- and as we've discussed before some people might want to pull the library independently of Beman. I do not want to hold the PR for this comment -- but just something to think about.

@neatudarius
Copy link
Member Author

neatudarius commented Dec 20, 2024

I'm coming in late here, but wow this looks really great to me -- especially using the logos!

Thanks! I will merge it and do follow-up PRs.

I didn't read the whole history, but one thing I'll just mention that we might want to express somewhere is that retired really means it's been removed from the main distribution. The author might actually still be supporting -- and as we've discussed before some people might want to pull the library independently of Beman. I do not want to hold the PR for this comment -- but just something to think about.

I actually tried to apply your exact suggestion in my last commit. Please check. I can tweak it (here or in a new PR).

Copy link
Member

@steve-downey steve-downey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to capture every nuance in a single label is probably impossible. This looks to me like it conveys the couple of highest order bits to let people know whether to continue investigating or not.

👍

@neatudarius neatudarius merged commit f90aec6 into bemanproject:main Dec 20, 2024
@inbal2l inbal2l self-requested a review December 23, 2024 14:40
Copy link

@inbal2l inbal2l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants