-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create the Beman Library Maturity Model #72
Create the Beman Library Maturity Model #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a first pass on the documents, looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better, left a few more comments. Thanks @neatudarius
@RaduNichita , please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good 👍
6332891
to
83d5ac8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added several comments to this PR. The most important is on the phase names. I think using descriptive names instead of introducing special parlance (like BEMAN DEVELOPMENT) will make it easier for readers to understand the status.
Here is what I suggested:
Before | After |
---|---|
BEMAN DEVELOPMENT | Under development and not yet ready for production use. |
BEMAN UNSTABLE | Production ready. API may undergo changes. |
BEMAN STABLE | Production ready. Stable API. |
It also solves the problem that "unstable" has a negative connotation without additional context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in support of the work Darius is doing here.
I would mark this "Approved", but a bunch of us Beman contributors discussed this PR just now in the weekly meeting. The feeling in the room was that breaking the document up into separate parts would be great. In particular:
- Conceptual docs about the Beman maturity model that are intended for users of Beman libraries
- One or more how-to guides intended for Beman contributors
65df1e5
to
fb3a595
Compare
fb3a595
to
f5eedad
Compare
@bemanproject/leads @camio @inbal2l @RaduNichita , pushed a completely new version of this PR. For the new file, please use the Example of expected usage in other repos: bemanproject/dump#6 |
3e7c993
to
5a6cab8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we generate logos as svg files?
1431be5
to
67b8322
Compare
df7cac7
to
b3655c4
Compare
I think we have enough information and replies (#72 (comment) and #72 (comment)) to conclude that at least the topic of adding an extra state for Beman libraries is controversial.
=============================================== My personal conclusion is that right now there is NO benefit from adding a new state. There is no obvious perfect solution, so just using =============================================== I would strongly suggest to move forward with an initial version as we don't actually have a need right now to possible distinguish between these cases. My proposal is to split this machinery into versions:
Anybody can try to propose an extension later. I would really want to be able to use this framework EOY, please! CC: @bemanproject/leads @inbal2l @camio @RaduNichita |
LGTM, thanks Darius! |
I'm coming in late here, but wow this looks really great to me -- especially using the logos! I didn't read the whole history, but one thing I'll just mention that we might want to express somewhere is that retired really means it's been removed from the main distribution. The author might actually still be supporting -- and as we've discussed before some people might want to pull the library independently of Beman. I do not want to hold the PR for this comment -- but just something to think about. |
Thanks! I will merge it and do follow-up PRs.
I actually tried to apply your exact suggestion in my last commit. Please check. I can tweak it (here or in a new PR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to capture every nuance in a single label is probably impossible. This looks to me like it conveys the couple of highest order bits to let people know whether to continue investigating or not.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update Beman Standard: add README.LIBRARY_STATUS - #77
As discussed in multiple syncs , we need to introduce a new document. The current proposal is to addBEMAN_PROCESS.md
and link it with theBEMAN_STANDARD.md
.Updates:
BEMAN_LIBRAY_MATURITY_MODEL.md
. Applied suggestions for 5 status values and their description from our last sync.README.LIBRARY_STATUS
into the Beman Standard.images/
where to store all images. e.g.images/logos
and others.