Skip to content

Conversation

HenriWahl
Copy link

Hi there,

this version lets me run FWBuilder 6.0.0-rc1 finally!

Might need some finetuning desktop-integration-wise and more documentation but works.

Uses Dockerfile for defined compile environment, creating a local flatpak repo which can be used for installing.

@HenriWahl HenriWahl mentioned this pull request Jan 5, 2021
@bellegarde-c
Copy link
Owner

Cool, you can send this to Flathub!

@HenriWahl
Copy link
Author

HenriWahl commented Jan 6, 2021

The app icon is still missing.

Edit: works now too.

@bellegarde-c
Copy link
Owner

I guess Flathub only accept json files. What is your issue with comments ?

@HenriWahl
Copy link
Author

HenriWahl commented Jan 6, 2021

I guess Flathub only accept json files.

YAML is OK: https://github.com/flathub/de.ifw_dresden.nagstamon/blob/master/de.ifw_dresden.nagstamon.yml

What is your issue with comments ?

If both formats are accepted I consider it a plus to be able to comment for example a commit hash to describe which version it is.

Edit: And less brackets are nice too :-)

@bellegarde-c
Copy link
Owner

ok, my bad. I personnaly prefere json BTW :D Waiting for this commited to flathub !!! Thanks for finishing this thing.

@HenriWahl
Copy link
Author

ok, my bad. I personnaly prefere json BTW :D Waiting for this commited to flathub !!! Thanks for finishing this thing.

Maybe you can find out how to add it to flathub?

@bellegarde-c
Copy link
Owner

You just need to do a pull request to flathub repository.

https://github.com/flathub/flathub/pulls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants