Skip to content

Add a missing period #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: lektor
Choose a base branch
from
Open

Add a missing period #687

wants to merge 1 commit into from

Conversation

johnzhou721
Copy link
Contributor

@johnzhou721 johnzhou721 commented Jul 1, 2025 •
edited
Loading

DO NOT MERGE!!!!

This is a part of testing #686.

Workflow is as follows:

  1. Review + merge Pull Weblate Changes Before Updating Translations #686.
  2. Fixup the Chinese Simplified translation of this string but don't download the file so Weblate won't commit it yet.
  3. Merge this PR, wait until Update Translations finishes running, then download the translations files from Weblate to force a commit. If it doesn't commit anything, great; we've forced it to bee-fore we updated the translations. If it does, and conflicts happens, that means Pull Weblate Changes Before Updating Translations #686 is not effective.

RIGHT NOW we're before step 1.

EDIT NOTE step 3 needs to be just a few hours after step 2 commits happens but has not yet committed.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@johnzhou721 johnzhou721 mentioned this pull request Jul 1, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnzhou721