Enable skipped tests #5363
Draft
Enable skipped tests #5363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
|
Now I'm waiting to see failures from the |
Merged
|
Given that this isn't passing the tests and #5362 is much larger, I think we should merge the other first. |
snejus
force-pushed
the
enable-skipped-tests
branch
from
d4a3f29 to
5337d41
Compare
This means that the dependencies must be installed for the tests to work. Otherwise, why do we have these tests that aren't being run?
unrar is actually not needed here.
snejus
force-pushed
the
enable-skipped-tests
branch
from
5337d41 to
c9702a4
Compare
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under #5362 me and @bal-e found out that
EmbedartCliTestdoes not run since it does notinherit from
unittest.TestCase.This PR fixes the above and another test that also had the same issue:
LRCLibIntegrationTest.Additionally, I went ahead and removed
unittest.skipfrom tests that are skipped becauseof missing dependencies, and added installation instructions for those dependencies in the
build.