Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: add dlss preset chooser #357

Open
wants to merge 1 commit into
base: feature/dlss_presets
Choose a base branch
from

Conversation

benjy3gg
Copy link

@benjy3gg benjy3gg commented Feb 3, 2025

As requested in #260, this PR allows choosing the DLSS Preset Similar to how NvidiaInspector does it.
This is using NVApi to set the Profile Settings.

I dont really have a clue about C# and WinUI, so if anything seems wrong lmk.
This is still WIP, just wanted to add it already so i can get some input.

image

@beeradmoore beeradmoore changed the base branch from main to feature/dlss_presets February 3, 2025 21:02
@beeradmoore beeradmoore self-assigned this Feb 3, 2025
@beeradmoore
Copy link
Owner

Thanks for this @benjy3gg. I'll take a look at it after I get v1.1.5 out the door

@beeradmoore
Copy link
Owner

Hey @benjy3gg , I haven't had time to look at this more yet. Asking because someone else asked, that find closest title what makes it per game?

What happens if you set it in NVIDIA App, can we use their value to show it as enabled, and vice versa if you set it here would it show as set in NVIDIA App (assuming the game is whitelisted)?

@benjy3gg
Copy link
Author

benjy3gg commented Feb 4, 2025

@beeradmoore beeradmoorethe problem with the nvidia profiles is that for some games, the title doesnt match correctly e.g. in dlss-swapper its "Diablo IV" but the profile in nvidia is called "Diablo 4".

i tried to fix this with the findbesttitle function. i have some additional fixes for this coming.

@beeradmoore
Copy link
Owner

Would knowing the path of the game executable help? Because we could find exes in the game folder as well and try find a match that way?

@beeradmoore
Copy link
Owner

Hey @benjy3gg , are you still working on this PR or is it ok if I bring it in into DLSS Swapper and keep working on it from there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants