fix(build): decode literal text in UDP payload probes - #938
Open
kydallaboutlearning wants to merge 4 commits into
Open
kydallaboutlearning wants to merge 4 commits into
kydallaboutlearning wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SNMP agents never answered RustScan's port-161 probe because the
nmap-payloadsdecoder inbuild.rskept only ASCII hex digits: the literalpubliccommunity string collapsed to the single byte0xbc, producing a 28-byte probe instead of 33 (and NetBIOS/LDAP/SSDP probes with literal text were mangled the same way).This rewrites the decoder to Nmap's C-style escape format:
\xNNand single-char escapes decode, every other character contributes its literal bytes, and multi-line quoted segments concatenate with no separators (honoring\"escapes). Also passes the block text to the decoder from its opening quote (previously the first quote was pre-stripped, breaking segment pairing), and strips CR line endings so CRLF checkouts parse identically to LF ones.Verified end-to-end through the generated payload map:
Gate (matches
just test):cargo testall green,cargo clippy -- --deny warnings+cargo clippy --tests -- --deny warningsclean,cargo fmt --checkclean,cargo docclean.Closes #933