-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BRC-85] Upgrade to latest LTS node 22 #257
Conversation
This is fine for now. I feel like I'm seeing those warnings everywhere now. |
I just bumped a package to node 22 actually and I just ran through all my scripts and added:
very annoying but it is what it is... we should do this for core as well |
If this continues to be a problem then maybe the shebang approach is how all of our scripts should work. More boilerplate but it can be copy/pasted. There doesn't seem to be a way to set NODE_OPTIONS globally and I don't want to use shell stuff to mask the issue as I want node configured exactly like it will be in the container. I still don't understand where this punycode crap comes from is there an issue you can link to so we can follow it? |
Re Re punycode doing I think there 3 modules we have bedrock core api that is causing a problem, if recall correctly its related to google cloud storage and something else. |
I think we should be able to do: |
Ok this just hit me in another package and I went deep. It's just so, so stupid. I had an even bigger problem which is that even if
What makes it worse is I was relying on binaries which need to be executables so the consumer MUST include that flag (and even know how what's going on). Looking at the deps there's a million things relying on punycode and others. I thought about opening issues with them but there's 4 places and they're deep in the chain. No one is going to fix this until node actually breaks it and meantime I don't want to look at it so I made this: https://github.com/bedrockio/node-warnings just require |
@andrewplummer i have added back the circular-dependency-plugin + remove the disabling of warnings, after merge lets add in the https://github.com/bedrockio/node-warnings. |
Worth mentioning:
I have added suppression for the "punycode module is deprecated", thats the
--disable-warning=DEP0040
In web I have remove the circular-dependency-plugin due
The
util._extendAPI is deprecated.
I think we can remove this safety net.