Skip to content

Conversation

@789-raghu
Copy link

No description provided.

Copy link

@Imran-imtiaz48 Imran-imtiaz48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request introduces some CSS changes to the project. Below are my observations and suggestions:

Specific Feedback
.skills__content Grid Update

The addition of grid-template-columns: repeat(2, max-content); is a good improvement for better alignment of skill items. Ensure this change doesn't cause overflow issues on smaller viewports.
.work__container, .info__container, .services__container, .contact__container Updates

Changing grid-template-columns to 350px seems like a fixed width that could potentially cause layout issues on devices with smaller screens. Consider using a relative unit (e.g., % or fr) or media queries to ensure responsiveness.
.nav Height Calculation

The height calculation using calc(var(--header-height) + 2rem) is a solid approach. Just verify that it integrates seamlessly with the rest of the layout and doesn't cause unexpected gaps or overlaps.
Suggestions for Improvement
Responsive Testing: Ensure all these changes are tested on different screen sizes to maintain a responsive design.
Consistency: Verify that the new styles align with the existing design system, including spacing, alignment, and proportions.
Browser Compatibility: Confirm that the use of properties such as grid-template-columns works consistently across all supported browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants