Support collection.abc.Mapping as resource instead of only dict

[axelv]

This slight modification to the engine relaxes the assumption that a resource node must be a Python dictionary by changing
some isinstance checks:

- if isinstance(node.data, dict):
+ if isinstance(node.data, Mapping):

This allows us to pass Pydantic objects or dataclasses and preserve metadata and methods defined on those objects and solves the issue described here #43.

Let me know what you think and if adaptation are needed 🙌

FYI: I think a similar relaxation of list to Sequence would also be possible 🙂

[axelv]

@ruscoder What do you think of this approach?

[ruscoder]

Hi @axelv, it looks good to me, thanks.

[axelv]

FYI: I think a similar relaxation of list to Sequence would also be possible 🙂

@ruscoder what do you think of this? Is it OK if I start a PR for this?

[ruscoder]

@axelv it will be great to have it here

[axelv]

FYI: I think a similar relaxation of list to Sequence would also be possible 🙂

This is harder than I thought because str is also a Sequence 🤔

[ruscoder]

@axelv consider using MutableSequence

In [4]: isinstance("ok", MutableSequence)
Out[4]: False

In [5]: isinstance((1,2,3), MutableSequence)
Out[5]: False

In [6]: isinstance([1,2,3], MutableSequence)
Out[6]: True

[ruscoder]

@axelv btw, do you have a real-world use case for using list-like structures together with fhirpath py?

[axelv]

Yes, I want create custom lists to make slices accessible by name in Python: https://github.com/axelv/pydantic-fhir-slicing
But still work in progress