Move rawtunes out to a separate file#134
Open
estellecomment wants to merge 4 commits intobeatboxjs:mainfrom
Open
Move rawtunes out to a separate file#134estellecomment wants to merge 4 commits intobeatboxjs:mainfrom
estellecomment wants to merge 4 commits intobeatboxjs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#127
This is the minimal change to make it easy to swap out tunes. Only one file needs to be edited, and that file contains no code (almost!) apart from the tunes data.
It includes some explanation comments to help get started. The README is also updated.
This is probably still a bit tricky to do for people with little technical background, but I don't think you would end up doing this task without any technical background anyway.
TODO : edit https://player-docs.rhythms-of-resistance.org/guide/technical/config.html to mention the new file rawTunes.ts instead of the old defaultTunes.ts (I don't have access to it)