types #143
types #143
Conversation
yagebu
commented
Jan 3, 2025
yagebu
commented
- adjust types for a successful mypy run
- ci: add mypy ci step
yagebu
force-pushed
the
types
branch
4 times, most recently
from
c4138e4 to
0b55392
Compare
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.9' |
There was a problem hiding this comment.
that's the oldest supported version of Beancount - which version do you want?
| @@ -155,7 +155,7 @@ def get_file(filename): | |||
| return _CACHE[filename] | |||
|
|
|||
|
|
|||
| _CACHE = utils.DefaultDictWithKey(_FileMemo) | |||
| _CACHE = utils.DefaultDictWithKey(_FileMemo) # type: ignore | |||
There was a problem hiding this comment.
Why is the ignore needed?
There was a problem hiding this comment.
DefaultDictWithKey is not typed correctly - it inherits the types from defaultdict but takes a default function which takes one argument. Shall I add a comment explaining that?
| @@ -5,7 +5,7 @@ | |||
|
|
|||
|
|
|||
| class Importer(csvbase.Importer): | |||
| date = csvbase.Date('Posting Date', '%m/%d/%Y') | |||
| date = csvbase.Date('Posting Date', '%m/%d/%Y') # type: ignore | |||
There was a problem hiding this comment.
This date column shadows the date function of the importer protocol. Seems like the base class initialisation makes that all work but I don't know if this can be typed correctly.
examples/importers/utrade.py
Outdated
| index = 0 | ||
| with open(filepath) as infile: | ||
| for index, row in enumerate(csv.DictReader(infile)): | ||
| meta = data.new_metadata(filepath, index) | ||
| date = parse(row['DATE']).date() | ||
| rtype = row['TYPE'] | ||
| link = f"ut{row['REF #']}" | ||
| links = frozenset([link]) |
There was a problem hiding this comment.
These two lines can be one line.
| @@ -122,9 +123,9 @@ def extract(self, filepath, existing): | |||
| rate = D(match.group(3)) | |||
|
|
|||
| if rtype == 'BUY': | |||
| cost = position.Cost(rate, self.currency, None, None) | |||
| cost = position.CostSpec(rate, None, self.currency, None, None, None) | |||
There was a problem hiding this comment.
Why? Cost should be just fine.
There was a problem hiding this comment.
a Cost requires a date (the booking code will insert it for all postings, falling back to the entry date)
| @@ -143,11 +144,11 @@ def extract(self, filepath, existing): | |||
| logging.error("Missing cost basis in '%s'", row['DESCRIPTION']) | |||
| continue | |||
| cost_number = D(match.group(1)) | |||
| cost = position.Cost(cost_number, self.currency, None, None) | |||
| cost = position.CostSpec(cost_number, None, self.currency, None, None, None) | |||
| links.add(link) | ||
| tag = getattr(rec, "tag", None) | ||
| if tag: | ||
| tags.add(tag) |
There was a problem hiding this comment.
I'm not entirely convinced that the type for links and tags should be frozenset and not simply collections.abc.Set. Anyhow, This seems a very convoluted way to crete a frozenset of one element.
There was a problem hiding this comment.
I stuck to the original code but I'm happy to refactor this as well
Some type: ignores were added but only internal uses of functionality.
