Find plugins on linux. #233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to be searching relative to the location of libhmsbeagle.so When using libhmsbeagle.so in the build directory, we need to explicitly search the CPU, GPU, and JNI subdirs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is semi-analogous to Mac line:
It contains two parts.
libhmsbeagle.sois set to$ORIGINso that it looks for plugins in the same directory as itself. The RPATH is searched before LD_LIBRARY_PATH.The benefit of this is that if there is a different beagle installation (in /usr/local/ for example)
libhmsbeagle.sowill use the plugins in the same directory as itself in preference to the ones in /usr/local.libhmsbeagle.soin the build directory before installation. Such RPATHS are used to run executables before installation and are erased during installation.The benefit of setting RPATH in the build directory is so that when we run the examples (i.e. ./build/examples/hmctest) they will know how to find the plugins.