Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename some of the properties, to make them more intuitive #2657

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Rename some of the properties, to make them more intuitive #2657

merged 1 commit into from
Jan 25, 2025

Conversation

be5invis
Copy link
Owner

No description provided.

@be5invis be5invis enabled auto-merge (squash) January 25, 2025 20:15
@be5invis be5invis merged commit b3022f1 into dev Jan 25, 2025
6 checks passed
@be5invis be5invis deleted the b/rename-divframe-parameters branch January 25, 2025 21:55
@jmcwilliams403
Copy link
Contributor

I would like to point out that [DivFrame].advs could possibly be misunderstood as being related to AdviceStroke instead of being a shortening of AdvanceScale{MM|M|T|F|I|II}

@be5invis
Copy link
Owner Author

be5invis commented Jan 26, 2025 •
edited
Loading

I don't think we ever abbrivated adviceStroke so this should be fine.
Changing to adws could be better though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@be5invis @jmcwilliams403