Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize glyphs/variants of three non-slavic Cyrillic letters. #2285

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

jmcwilliams403
Copy link
Contributor

@jmcwilliams403 jmcwilliams403 commented Apr 9, 2024

Schwa top hook behavior:
ОоӨөЭэӘә
(not shown is real turned e which is unchanged).
Upright:
image
Italic:
image
Compared to slab:
Upright:
image
Italic:
image
Cyrillic Straight U behavior:
All Capital U variants:
УЎҮҰ
image
All Lower U variants:
уўүұ
image

@be5invis
Copy link
Owner

be5invis commented Apr 9, 2024

I don't think ogoneks are widely used for Ҙҙ Ҫҫ Ҿҿ. Let us just follow the Unicode chart.

packages/font-glyphs/src/letter/latin/c.ptl Outdated Show resolved Hide resolved
packages/font-glyphs/src/letter/greek/lower-epsilon.ptl Outdated Show resolved Hide resolved
packages/font-glyphs/src/letter/latin/lower-e.ptl Outdated Show resolved Hide resolved
@mi2ebi
Copy link

mi2ebi commented Apr 9, 2024

the unicode charts do not prescribe glyphs

@jmcwilliams403 jmcwilliams403 changed the title Harmonize glyphs/variants of several non-slavic Cyrillic letters. Harmonize glyphs/variants of three non-slavic Cyrillic letters. Apr 10, 2024
@jmcwilliams403
Copy link
Contributor Author

I kept some of the code cleanup and the cyrl/Dhe rename but otherwise the descender glyphs are back to normal.

@jmcwilliams403 jmcwilliams403 requested a review from be5invis April 10, 2024 13:17
@be5invis be5invis merged commit 6645ef3 into be5invis:dev Apr 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants