Skip to content

Conversation

@mhidalgo-rai
Copy link

This patch adds package changelogs and pushes ROS 2 patches under the 4.1.0 version in preparation for the first binary release.

Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Copy link

@khughes-bdai khughes-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mhidalgo-rai
Copy link
Author

mhidalgo-rai commented Dec 3, 2024

I'm not super fond of the approach of having a separate branch that mutates what each Spot C++ SDK version includes, but the alternatives are worse (e.g. having patches in the release repository, I've had to chase those down before and it's no fun).

@mhidalgo-rai mhidalgo-rai merged commit c92a9b9 into ros2 Dec 3, 2024
1 check passed
@mhidalgo-rai mhidalgo-rai deleted the mhidalgo-bdai/bosdyn-4.1.0 branch December 3, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants