Fix cycles during emission (fix #376, fix #323) #453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: This is a breaking change, that changes names for some emitted types. It will require a major version bump.
Context
The problem: when emitting TS, we can run into a cycle when the emitted AST:
The approach in this PR
This PR has 2 parts:
onDereference
hook that we can use to grab the original$ref
path for dereferenced schemas.$ref
s to more correctly name emitted types.(2) is something I've wanted to do for a while. It gives us more correct behavior (which we only approximated before), and more fully deals with cyclical references.
Alternative solutions considered