compileFromDir (aka batch compile) #101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcherny
reviewed
Jun 23, 2017
There was a problem hiding this comment.
Hi @tomholford! Is the purpose of this PR to get early feedback, or just to track your progress?
|
@bcherny Both :) Sketched out an idea to address #16 and wanted to see if it's congruent with your roadmap before investing more time into it. Further, wanted to solicit feedback on the interface - i.e. should this be available via CLI? And if so, what would the command look like? For example: where |
|
@tomholford See this comment and the one after it - does that seem reasonable to you? |
|
@tomholford Closing for inactivity. Feel free to reopen when/if you get back to this. |
|
@bcherny Thanks, will re-open later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this a WIP implementation to address #16
Call
compileFromDirwith a list of filenames and the optional options hash (same method signature ascompileFromFile)todo: