-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
Perf test for comparison of 2 impl of unquoting
|
WIP, but is already open for a feedback |
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
Here are the updated benchmark, including simpler impl suggested in #64 (comment)
It is not just simpler, but is even a bit faster! 👏 |
Signed-off-by: Alexander Bezzubov <[email protected]>
All feedback addressed, ready for another round. |
Co-Authored-By: bzz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor cosmetic comments, otherwise looks good to me!
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests need some changes :)
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
@creachadair @dennwc thank you very much for thorough and prompt reviews! All feedback addressed, ready for another round. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more suggestion on the comment, but I think this is in good shape.
Thanks for your patience!
Signed-off-by: Alexander Bezzubov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only one small change remains.
Signed-off-by: Alexander Bezzubov <[email protected]>
🎉 merging as soon as CI is green. Thank you everyone for your kind reviews! |
Fixes #62
TODOs
strconv_test.go
TestUnquoteSingle
pass:modify
unquoteSingle
, so\0
is handled like escape sequence, resulting inU+0000
TestUnquoteSingleAndQuoteBack
pass:modifyquoteSingle
soU+0000
is handled like in JS and results in\0
(instead of Go\x00
)That is not possible as right now we are loosing information of the type of escape sequence being used in JS (
\000
,\x00
, and\0
- all end up quoted back in Hex format)Instead, test fixtures are update to use this canonical form.