This repository was archived by the owner on Mar 8, 2020. It is now read-only.
sem: drop 'leadingComments' inside import 'specifiers' #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/babel/babel/blob/master/packages/babel-parser/ast/spec.md#importnamespacespecifier may have a 'leadingComments' field Signed-off-by: Alexander Bezzubov <[email protected]>
dennwc
approved these changes
Feb 22, 2019
bzz
added a commit
to bzz/javascript-driver
that referenced
this pull request
Mar 3, 2019
Instead of dropping comments of ImportNamespaceSpecifier as implemented in bblfsh#60, we just skip both, leading and trailing comments now. This avoids loosing a Comment node in UAST. Signed-off-by: Alexander Bezzubov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #59 WITHOUT update to the latest SDK.
It is related to how comments are treated in case of import specifiers. Sometimes specifier may have a 'leadingComments' field - this change knocks it off by the preprocessor.
This is my first annotation attempt, and the approach will most probably change after SDK update.