This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Fix string literal escapes #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Bezzubov <[email protected]>
Now native Java AST contains both - escapedValue - unescapedValue obtained from JDT parser. That is similar to what javasript driver does and allows to avoid having language-spacific escape sequence handling on the Go side that can be different from Go one. See bblfsh#111 (comment) for details. Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
dennwc
approved these changes
Apr 16, 2019
creachadair
approved these changes
Apr 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111 by padding a new
unescapedValuenode to StringLiteral in native driver.It is acquired though JDT parser, follows escape sequence logic in Java and is used only in Semantic mode, similar to bblfsh/javascript-driver#81 (comment)