Offset out of bounds #45

Activity

1. ncordon

   added

   bug

   on Jul 24, 2019
2. kuba--

   self-assigned this

   on Aug 20, 2019
3. kuba-- commented on Aug 20, 2019

   

   kuba--

   on Aug 20, 2019

   Last edited by kuba--

   Member

   More actions

   It's the CDT's issue. It cannot handle ambiguities for ellipsis (...)in parameter declaration.
   For instance following function (LocOffsetEnd: 19, LocOffsetStart: 0):

   void foo(int&...);

   takes various number of int references. In CDT ... notation is called ellipsis. A parser parses all tokens correctly but at the end it visits CPPASTAmbiguityResolver, which tries to resolve ambiguity, what calls CPPASTAmbiguousParameterDeclaration.doResolveAmbiguity.
   This class is responsible for:

   Handles ambiguities for ellipsis in parameter declaration.
   template<typename... T> void function(T ...); // is T a parameter pack?

   and it tries to adjustOffsets(dtor).
   Unfortunately the function does not work well if we have any parameters next to the type (&, *).
   Here is a snippet from adjustOffsets function:

   final ASTNode first = (ASTNode) ptrOps[0];
   final ASTNode last = (ASTNode) ptrOps[ptrOps.length - 1];
   asNode.setOffsetAndLength(first.getOffset(), last.getOffset() + last.getLength());

   We have only one param &, so the first and last point to the same node with offset 12 and length 1.
   In my opinion the function setOffsetAndLength (which overwrites position) is called incorrectly, because the second parameter value (last.getOffset() + last.getLength()) points to the end offset, but the function signature is:

   void setOffsetAndLength(int offset, int length)

   so, now if we try to calculate the end offset it will be offset + length.
   In our case original offset was 12, length 1, but after adjust the length was 12 + 1 = 13, so the end offset is 25, what in our case it goes out of bounds [0, 19]

                  'Prop_Name': {
                     IASTClass: "CPPASTName",
                     LocOffsetEnd: 8,
                     LocOffsetStart: 5,
                     Name: "foo",
                       },
                  'Prop_Parameters': [
                           {
                        DeclaresParameterPack: false,
                        IASTClass: "CPPASTDeclarator",
                        LocOffsetEnd: 25,        <---------------------- OUT OF BOUNDS
                        LocOffsetStart: 12,
                        'Prop_Name': {
                           IASTClass: "CPPASTName",
                           Name: "",
                               },
   

   👍React with 👍1Reacted by Denys Smirnov
4. kuba-- commented on Aug 21, 2019

   

   kuba--

   on Aug 21, 2019

   Member

   More actions

   https://bugs.eclipse.org/bugs/show_bug.cgi?id=550310
5. kuba--

   added

   blocked

   on Aug 21, 2019