WSTEAMA-1515-added support for routes to have variants at the end #12333
+256
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for having this all in one commit, I made the changes on latest and then transferred them to a new branch and was having issues with git. |
…-script-at-the-end
…e-end' of github.com:bbc/simorgh into WSTEAMA-1514-update-topics-urls-to-include-script-at-the-end
amoore108
reviewed
Jan 24, 2025
Comment on lines
+125
to
+126
| ${TOPIC_PAGE} | ${'zhongwen'} | ${'trad'} | ${'live'} | ${'/zhongwen/topics/cpydz21p02et/trad'} | ${'https://mock-bff-path/?id=cpydz21p02et&service=zhongwen&pageType=topic&variant=trad&serviceEnv=live'} | ||
| ${TOPIC_PAGE} | ${'zhongwen'} | ${'simp'} | ${'live'} | ${'/zhongwen/topics/c4vmr03pyn6t/simp'} | ${'https://mock-bff-path/?id=c4vmr03pyn6t&service=zhongwen&pageType=topic&variant=simp&serviceEnv=live'} |
There was a problem hiding this comment.
Do we need similar examples for local and test environments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves (https://jira.dev.bbc.co.uk/browse/WSTEAMA-1514)
Overall changes
Added support for routes with variants such that the variant is at the end of the script. e.g.
Before: /service/variant/topics/id
After: /service/topics/id/variant
Code changes
Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines