Skip to content

don't use submit buttons #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

don't use submit buttons #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/components/media-player/src/PlayerControls/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ class PlayerControls extends React.Component {
render() {

const pictureInPicture = ('pictureInPictureEnabled' in document) ? ( <button
type="button"
value="Picture-in-picture"
title="Picture-in-picture"
className={ `${ style.playerButton } ${ style.pip }` }
Expand All @@ -64,6 +65,7 @@ class PlayerControls extends React.Component {

<div className={ style.btnsGroup }>
<button
type="button"
value="seek backward by a set interval: alt r"
title="seek backward by a set interval: alt r"
className={ style.playerButton }
Expand All @@ -72,6 +74,7 @@ class PlayerControls extends React.Component {
</button>

<button
type="button"
value="seek backward: alt j"
title="seek backward: alt j"
className={ style.playerButton }
Expand All @@ -82,6 +85,7 @@ class PlayerControls extends React.Component {
</button>

<button
type="button"
value="Play/Pause: alt k"
title="Play/Pause: alt k"
className={ style.playerButton }
Expand All @@ -92,6 +96,7 @@ class PlayerControls extends React.Component {
<button
value="seek forward: alt l"
title="seek forward: alt l"
type="button"
className={ style.playerButton }
onMouseDown={ this.setIntervalHelperForward }
onMouseUp={ this.clearIntervalHelper }
Expand All @@ -111,6 +116,7 @@ class PlayerControls extends React.Component {
{pictureInPicture}

<button
type="button"
value="Toggle Sound"
title="Toggle Sound"
className={ style.playerButton }
Expand Down
1 change: 1 addition & 0 deletions packages/components/transcript-editor/src/ExportOptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ class ExportOptions extends React.Component {
render() {
const btns = this.props.exportOptionsList.map((opt, index) => {
return (<><button
type="button"
key={opt.label+index}
title={ opt.label }
className={ style.playerButton }
Expand Down
3 changes: 3 additions & 0 deletions packages/components/transcript-editor/src/Header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,20 +32,23 @@ class Header extends React.Component {

<div className={ style.settingsContainer }>
<button
type="button"
className={ style.settingsButton }
title="Settings"
onClick={ props.handleSettingsToggle }
>
<FontAwesomeIcon icon={ faCog } />
</button>
<button
type="button"
className={ `${ style.settingsButton } ${ style.keyboardShortcutsButon }` }
title="view shortcuts"
onClick={ props.handleShortcutsToggle }
>
<FontAwesomeIcon icon={ faKeyboard } />
</button>
<button
type="button"
className={ `${ style.settingsButton }` }
title="Export"
onClick={ props.handleExportToggle }
Expand Down