Fix TimeRange __contains__ and add Timestamp __float__#94
Merged
philipnbbc merged 3 commits intomainfrom Feb 10, 2025
Merged
Conversation
added 3 commits
February 5, 2025 14:03
Call `contains_subrange` to ensure correctness and consistency sem-ver: bugfix
sem-ver: feature
This allows float(Timestamp) to be used instead of Timestamp.to_float. This helps to convert TimeRange.length into a float in one go by doing float(TimeRange.length). sem-ver: feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR:
TimeRange.__contains__which wrongly returnedFalseforTimeRange.from_str("[0:0_1:0)") in TimeRange.eternity()for example.TimeRange.__contains__, which is equivalent to usingcontains_subrange.Timestamp.__float__which simplifies and avoids typing issues when converting aTimeRange.lengthto afloat.Jira Issue
Jira URL: https://jira.dev.bbc.co.uk/browse/CLOUDFIT-5398
Related PRs
Where appropriate. Indicate order to be merged.
Links to external test runs/working deployment
Where appropriate, if separate to default CI run
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on Cloudfit PRs