Bring strip_level configuration up to top level #3434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
nmattia
added a commit
to dfinity/ic
that referenced
this pull request
Jul 18, 2025
This will allow us to keep up to date with new changes and to cherry-pick our patches more cleanly (bazelbuild/rules_rust#3434, bazelbuild/rules_rust#3510)
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Jul 21, 2025
This will allow us to keep up to date with new changes and to cherry-pick our patches more cleanly (bazelbuild/rules_rust#3434, bazelbuild/rules_rust#3510)
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Jul 21, 2025
This will allow us to keep up to date with new changes and to cherry-pick our patches more cleanly (bazelbuild/rules_rust#3434, bazelbuild/rules_rust#3510)
|
I've cleared up the CLA check https://github.com/bazelbuild/rules_rust/pull/3434/checks?check_run_id=41742317674, do you think someone could take a look at this PR? |
|
Any update here? |
illicitonion
approved these changes
Aug 25, 2025
nmattia
added a commit
to dfinity/ic
that referenced
this pull request
Sep 2, 2025
This new version supports rust 1.89.0 and includes two of our local patches that were upstreamed: * bazelbuild/rules_rust#3560 * bazelbuild/rules_rust#3510 * bazelbuild/rules_rust#3434
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Sep 4, 2025
This new version supports rust 1.89.0 and includes two of our local patches that were upstreamed: * bazelbuild/rules_rust#3560 * bazelbuild/rules_rust#3510 * bazelbuild/rules_rust#3434
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Sep 4, 2025
This new version supports rust 1.89.0 and includes two of our local patches that were upstreamed: * bazelbuild/rules_rust#3560 * bazelbuild/rules_rust#3510 * bazelbuild/rules_rust#3434
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a path for configuring
strip_levelin the same way asopt_level. This will allow configuration away from the default of:through
rust_register_toolchains.