Create internal rust_binary rule instead of using transitions #1187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like a cleaner way to break the dependency that rust_binary has on the process wrapper. The common args are consumed and modified to set the process wrapper to None, which is detected and performs the appropriate switch. The transitions and settings can then be removed.
|
I can confirm that this fixes some cycles I was seeing when querying the bazel dependency graph after #1159. |
UebelAndre
requested changes
Mar 12, 2022
|
All of those changes look fine to me. I'll be able to get back to this later Sunday night, so feel free to update and merge. I think you should have permission. |
UebelAndre
approved these changes
Mar 12, 2022
|
Thanks! Indeed much simpler! |
hlopko
referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a cleaner way to break the dependency that rust_binary
has on the process wrapper. The common args are consumed and modified
to set the process wrapper to None, which is detected and performs the
appropriate switch. The transitions and settings can then be removed.