Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull java_stub_template.txt as an http_file #1270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pull java_stub_template.txt as an http_file #1270

wants to merge 1 commit into from

Conversation

Bencodes
Copy link
Collaborator

No description provided.

Bencodes
Bencodes commented Jan 30, 2025
View reviewed changes
MODULE.bazel
@@ -19,6 +19,7 @@ use_repo(
"com_github_jetbrains_kotlin",
"com_github_jetbrains_kotlin_git",
"com_github_pinterest_ktlint",
"java_stub_template_txt",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being removed from Bazel and doesn't seem to be exposed by rules_java anymore.

@restingbull
Copy link
Collaborator

Per #1267, we need to copy the template into the repo.

@nkoroste had issues with CI downloading this, and it will probably go away/move in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahumesky ahumesky Awaiting requested review from ahumesky ahumesky is a code owner

@cgruber cgruber Awaiting requested review from cgruber cgruber is a code owner

@restingbull restingbull Awaiting requested review from restingbull restingbull is a code owner

@nkoroste nkoroste Awaiting requested review from nkoroste nkoroste is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bencodes @restingbull