Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules_kotlin should migrate off @bazel_tools//tools/java:java_stub_template.txt #1267

Open
hvadehra opened this issue Jan 28, 2025 · 0 comments

Comments

@hvadehra
Copy link
Member

hvadehra commented Jan 28, 2025

It's used in a couple of places

default = Label("@bazel_tools//tools/java:java_stub_template.txt"),
and
default = Label("@bazel_tools//tools/java:java_stub_template.txt"),

The template now lives in @rules_java and in Bazel@HEAD the target in @bazel_tools is just a redirect. Given that the template is no longer versioned with Bazel, it can no longer be considered stable, and the Bazel team is looking to make bazel_tools empty in future releases anyway.

The code expanding the template must remain in sync with the template, the recommendation is to fork the template and maintain a local copy that matches the template expansion code. This will enable rulesets to evolve independently and keep the template always in sync with the rule code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants