Fixes Rust example 8 failing on downstream Bazel Head CI #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Hansen <[email protected]>
Signed-off-by: Marvin Hansen <[email protected]>
Signed-off-by: Marvin Hansen <[email protected]>
Signed-off-by: Marvin Hansen <[email protected]>
Signed-off-by: Marvin Hansen <[email protected]>
Signed-off-by: Marvin Hansen <[email protected]>
Signed-off-by: Marvin Hansen <[email protected]>
Signed-off-by: Marvin Hansen <[email protected]>
Signed-off-by: Marvin Hansen <[email protected]>
# Conflicts: # rust-examples/02-hello-cross/MODULE.bazel
# Conflicts: # rust-examples/.bazelversion # rust-examples/01-hello-world/MODULE.bazel # rust-examples/02-hello-cross/.bazelrc # rust-examples/02-hello-cross/MODULE.bazel # rust-examples/03-comp-opt/MODULE.bazel # rust-examples/04-ffi/MODULE.bazel # rust-examples/05-deps-cargo/MODULE.bazel # rust-examples/06-deps-direct/MODULE.bazel # rust-examples/06-deps-direct/MODULE.bazel.lock # rust-examples/07-deps-vendor/MODULE.bazel # rust-examples/07-deps-vendor/MODULE.bazel.lock # rust-examples/08-grpc-client-server/MODULE.bazel # rust-examples/08-grpc-client-server/MODULE.bazel.lock # rust-examples/08-grpc-client-server/thirdparty/all_deps.bzl # rust-examples/09-oci-container/MODULE.bazel
…eam HEAD Bazel version. Signed-off-by: Marvin Hansen <[email protected]>
marvin-hansen
requested review from
ahumesky,
jin,
gregestren and
Wyverald
as code owners
|
Resolves partially #540 |
Updated README.md Signed-off-by: Marvin Hansen <[email protected]>
Signed-off-by: Marvin Hansen <[email protected]>
|
Why do we have so many file changes? Some vendored file not removed? |
|
Because in order to do the crate annotation
necessary for the proto toolchain without vendoring,
i had to rewrite the entire example. It's one of the weirder things in
rules rust_that you just can flip the vendor mode on and off when you work
with custom or proto toolchains because the dependency path in the
annotation changes.
Looking back, using vendoring in that specific example to simplify working
with proto was a clear mistake I made back when drafting the example.
…On Mon, Feb 17, 2025 at 21:28 Yun Peng ***@***.***> wrote:
Why do we have so many file changes? Some vendored file not removed?
—
Reply to this email directly, view it on GitHub
<#554 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFYR7XDXDUASY5H2B4NUJE32QHPYNAVCNFSM6AAAAABXHHFED6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRTGE2DEOJXGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: meteorcloudy]*meteorcloudy* left a comment
(bazelbuild/examples#554)
<#554 (comment)>
Why do we have so many file changes? Some vendored file not removed?
—
Reply to this email directly, view it on GitHub
<#554 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFYR7XDXDUASY5H2B4NUJE32QHPYNAVCNFSM6AAAAABXHHFED6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRTGE2DEOJXGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I still don't understand why there are so many new files, I'm not fine with checking in a large number of files in this repo. I won't be able to review them. |
|
Actually, you are right. There is too much unrelated stuff. Sorry, I'm on my mobile and couldn't really see it. Let me move the changeset into a clean branch tomorrow and try again. |
|
Okay, @meteorcloudy I've filled a new PR with just the 7 affected files. Please review: #555 |
Wyverald
pushed a commit
that referenced
this pull request
Feb 18, 2025
Fixes Rust example 8 on downstream CI, as discussed in #540 Replaces the previous PR #554 Signed-off-by: Marvin Hansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves half of the failing Rust examples on downstream Bazel built from HEAD.
The two examples in questions are 7 and 8.
Example 7 is tricky and gets its own PR when I found a workaround.
This PR resolves example 8 by removing the vendoring that causes the build failure on downstream.