Move ios tutorial from bazel reference pages to examples repository. #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiuto
requested review from
floriographygoth and
susinmotion
and removed request for
brandjon,
susinmotion and
c-parsons
|
@keith @skofgar |
keith
approved these changes
Jan 19, 2022
aiuto
changed the title
copybara-service bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Dec 12, 2022
There have been talks about moving the ios-app tutorial outside the Bazel repo so that it's easier to iterate on and keep it up to date. A few weeks ago the tutorial now living in [rules_apple](https://github.com/bazelbuild/rules_apple) was [revamped](bazelbuild/rules_apple#1639). The corresponding example was also updated in bazelbuild/examples#258. In the Bazel site there are a few links that point to the ios-app page. This is why I opted for keeping the page in the site not to break links, but I'd be happier if we could simply provide a redirect in the Bazel site to the rules_apple tutorial text now living here: https://github.com/bazelbuild/rules_apple/blob/master/doc/tutorials/ios-app.md Some previous conversations: - #14499 - bazelbuild/examples#237 cc: @aiuto Closes #16985. PiperOrigin-RevId: 494660058 Change-Id: I7480be9798585e8523cb0cd3fe2993062aa38e7c
|
What's the state of this PR? I just had a ping on it but didn't realize it's been around for a long time now... |
alexeagle
reviewed
Sep 22, 2023
| @@ -0,0 +1,25 @@ | |||
| load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository") | |||
|
|
|||
| git_repository( | |||
There was a problem hiding this comment.
I don't think we should recommend git_repository since it has no entry in the Repository Cache.
Let's replace these with http_archive and also get the latest version?
|
@cgrindel maybe this is a good place to start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the iOS tutorial from the main bazel docs into this repository.
A follow up PR will remove https://docs.bazel.build/versions/main/tutorial/ios-app.html and point this new page instead.
Note that the tutorial is still a messy hodgepodge of stuff. The concept of the main vs source-only tree has not been maintained. The tutorial looks like it is a pure iOS app, but the examples we point you to are mixed appengine, java, ios.
Someone should clean this up. It will be much easier when the example code and the tutorial instructions are in the same repository.