Find V19+ basenames automatically. #471
Open
+493
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 15, 2025
helly25
force-pushed
the
feat/find_vs_predict_asename
branch
from
a78b6ff to
19b891c
Compare
|
Hi, what is the best way to discuss the following: |
… them by common prefixes in the database we anyway have. Rather then forcing maintainers to enter more complex information this keeps us at simply adding the versions as generated from the hasher script.
…he use of the finder algorithm
Add the missing distributions starting with 18.1.8. Exclude old style windows distributions if new style ones are present as well.
Fix lint error.
Add a test for the distribution finder. The test computes what would be found given all versions a nd a combination of arch and os. Then the test compares the result to what is configured and shows the difference. If the difference is empty then the finder is correct. There are currently only deleted entries with the last deleted enty in version 18.1.0. In other words starting with llvm version 18.1.1 the finder is correct. That also means as long as this is true, when someone adds information for a new version then the test does not need to be updated.
helly25
force-pushed
the
feat/find_vs_predict_asename
branch
from
19b891c to
9229bdb
Compare
|
Could you open a discussion and share it in the #cc channel? I don't think I'm a heavy enough user to decide whether this is useful or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue: #473
Instead of implementing a complex way of predicting the basename find them by common prefixes in the database we anyway have.
Rather then forcing maintainers to enter more complex information this keeps us at simply adding the versions as generated from the hasher script.
This should also ultimately put issue #464 and any future occurrence to rest.
There is a test that verifies which version cannot yet be found. That test shows that past 18.1.0 we can find all configured versions. Also the test shows that the main distribution types can all be found. That implies that we can write a function that finds the "latest" version for a given arch/os combo. For many people this will be the easiest way to get started and solves the issue that not always all arch/os versions have been prepared for all llvm versions. However, that functionality will have to wait for another patch - if at all doable and if people want that.
PR #472 is the more complete implementation that also supports version requirements.