-
-
Notifications
You must be signed in to change notification settings - Fork 605
feat(pypi): generate filegroup with all extracted wheel files #3011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rickeylev
wants to merge
13
commits into
bazel-contrib:main
Choose a base branch
from
rickeylev:feat.pypi.all.files
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ba62630
feat: generate filegroup with all extracted wheel files
rickeylev aac9bf7
feat(pypi): Add filegroup for all extracted wheel files
google-labs-jules[bot] a68c31e
Merge branch 'main' of https://github.com/bazel-contrib/rules_python …
rickeylev 63af927
Merge and fix changelog
rickeylev 80ac1f7
fix up filegroup arg
rickeylev ee51ad2
add version note
rickeylev 021746b
remove defunct todo
rickeylev c2a377a
fix var typo
rickeylev bc99905
pass sdist filename along
rickeylev de1a3e0
Merge branch 'main' of https://github.com/bazel-contrib/rules_python …
rickeylev 0674887
Merge branch 'feat.pypi.all.files' of https://github.com/rickeylev/ru…
rickeylev 1f03a3f
exclude build file from all files target
rickeylev 8b820e1
exclude more special bazel files
rickeylev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -79,6 +79,7 @@ load( | |
":labels.bzl", | ||
"DATA_LABEL", | ||
"DIST_INFO_LABEL", | ||
"EXTRACTED_WHEEL_FILES", | ||
"PY_LIBRARY_IMPL_LABEL", | ||
"PY_LIBRARY_PUBLIC_LABEL", | ||
"WHEEL_FILE_IMPL_LABEL", | ||
|
@@ -151,6 +152,7 @@ def pkg_aliases( | |
WHEEL_FILE_PUBLIC_LABEL: WHEEL_FILE_IMPL_LABEL if group_name else WHEEL_FILE_PUBLIC_LABEL, | ||
DATA_LABEL: DATA_LABEL, | ||
DIST_INFO_LABEL: DIST_INFO_LABEL, | ||
EXTRACTED_WHEEL_FILES: EXTRACTED_WHEEL_FILES, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. todo: add a test for this. Just need to have some that references it. |
||
} | { | ||
x: x | ||
for x in extra_aliases or [] | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.