chore: remove old versions of Python 3.8#2700
Conversation
|
Just realized that we will need |
This doesn't make sense to me. It makes sense to say that we aren't going to manage EoL'd interpreters. I'm less sold on dropping the old requirements configurations deliberately, but deliberately breaking a back revision and creating an upgrade barrier seems like not our job. |
|
Just to be clear what I meant about the above is that we depend on protobuf and protobuf is declaring the python 3.8 toolchains and pip.parse with python 3.8 and that can cause issues. I was thinking of a way for this to not break. Probably the best first step is to leave a single 3.8 version there and remove the earlier ones. |
0f72024 to
8ec9c75
Compare
|
I don't mind removing our tests for it and basically saying "rules_python stuff may or may not work with a 3.8 runtime" But yeah, I don't like the idea that e.g. I think leaving the latest 3.8 version is a decent compromise. |
Python 3.8 has reached EOL and this PR removes old toolchains and most
of the tests. Users can still use it if they register the toolchains
themselves, but
rules_pythonwill no longer keep testing the toolchains.Removing the toolchains all-together will be done at a later stage which
may require us to be more clever how we handle asks to include
3.8. Maybewe can just fail if the user asks for a python version that does not exist,
but I am concerned that
rules_pythondepending onprotobufmay pull incode that requests
3.8. I'll look at this at some later time.