fix(whl_library): stop duplicating deps in whl_library #1874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR we would incorrectly add deps to the platform-specific list if there were multiple entries in the `METADATA` file. It seems that some projects (e.g. [opencv-python]) have multiple entries in their METADATA file to help SAT solvers with selecting the right version when different interpreter versions are used. In our case, we will have only one version of a given package because we are operating with a locked dependency list, so we should ensure that we do not have duplicates across the lists. With this PR we are solving this during the construction of the dependency sets so that the internal model is always consistent. Fixes bazel-contrib#1873 [opencv-python]: https://pypi.org/project/opencv-python/
rickeylev
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR we would incorrectly add deps to the platform-specific
list if there were multiple entries in the
METADATAfile. It seemsthat some projects (e.g. opencv-python) have multiple entries in their
METADATA file to help SAT solvers with selecting the right version when
different interpreter versions are used.
In our case, we will have only one version of a given package because we
are operating with a locked dependency list, so we should ensure that we
do not have duplicates across the lists. With this PR we are solving
this during the construction of the dependency sets so that the internal
model is always consistent.
Fixes #1873