Ensure that data
from code_libraries are included
#262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When a
jsonnet_library
defined adata
dependency and thejsonnet_library
was included in a{tla,ext}_code_libraries
(See updated//:extvar_code_library_test
) thedata
was not being included which results in error like:Digging into the sandbox, the
data
file (files.txt
in the example//:extvar_code_library_test
) looks like:Resolution
Adding the missing addition of the
data_runfiles
to thetransitive_data
injsonnet_to_json{,_test}
.Updated the example to make use of this as well.