-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade poetry2.0 & apply pep621 #545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, generally speaking. Will merge soon.
It seems a bit weird to install uv
, to then install poetry
later. Using just uv
would be nice in the future, but I'm a bit worried about breaking the publishing workflow. Something to keep in mind for the future.
I prefer uv to poetry, so I agree with the later change to uv. But I also agree with the concerns you mentioned. PS1. PS2. |
In that case I will wait with merging this :) |
i fixed it |
Thanks for the contribution :) |
What's different in poetry2.0: Announcing Poetry 2.0.0
Since poetry2.0 now supports pep621, I was able to modify pyproject.toml to conform to the standard spec.
(I kept the modifications to a minimum).
(Since install-poetry doesn't support poetry2.0, I've changed how to install poetry from github action. snok/install-poetry#164)
However, it does not yet support pep735 (dependency groups), so the proprietary specification
tool.poetry.group
is retained.However, this too will be fixed in the future. python-poetry/poetry#9751
If we use poetry in the future, it seems like a good idea to upgrade poetry to 2.0 if possible, as all improvements will only be for 2.0 or later.