Skip to content

Conversation

@stefanradev93
Copy link
Contributor

@stefanradev93 stefanradev93 commented Oct 6, 2025

This PR addresses #583 by making the following changes:

  • The method plot_default_diagnostics shows both ECDF and coverage plots, in addition to the other plots:
results_sir2
  • The method compute_default_diagnostics returns the log gamma statistic alongside ECE, in the same order as the above method:
results_sir

In addition, I did some small housekeeping by making small changes to the code and the docs, as well as the SIR notebook.

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
bayesflow/workflows/basic_workflow.py 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
bayesflow/diagnostics/plots/calibration_ecdf.py 78.57% <100.00%> (+5.84%) ⬆️
...agnostics/plots/calibration_ecdf_from_quantiles.py 86.48% <ø> (+8.10%) ⬆️
bayesflow/diagnostics/plots/coverage.py 97.14% <100.00%> (-0.36%) ⬇️
bayesflow/diagnostics/plots/loss.py 95.00% <ø> (ø)
bayesflow/diagnostics/plots/recovery.py 93.75% <ø> (ø)
bayesflow/workflows/basic_workflow.py 70.11% <66.66%> (+0.17%) ⬆️

Copy link
Contributor

@paul-buerkner paul-buerkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just found a typo in the doc. Feel free to merge otherwise :-)

- Z-score contraction plots.
Caution: For models with many parameters, plotting all marginal diagnostics becomes unwieldy. Consider
providing `variables_keyes` for visualizing the diagnostics for subsets of the parameter space.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in "keyes"

@stefanradev93 stefanradev93 merged commit b2a9ded into dev Oct 7, 2025
@stefanradev93 stefanradev93 deleted the improve-default-diag branch October 7, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants