-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make linear regression the quickstart notebook #310
Conversation
I have made some progress in making the diagnostic plots prettier and easier to use. Specifically, I added back the I know it's not super clean that I will put all of this in one PR but I don't have the time to make both the starter notebook pretty and fix all the plots at the same time if they are not on the same branch. |
More updates. I have now cleaned up the interface of the diagnostics and some of the related backend code. In particular, draws_stacked = bf.utils.dict_utils.dicts_to_arrays(
post_draws, val_sims,
)
f = bf.diagnostics.plots.pairs_posterior(
post_samples = draws_stacked["targets"][0],
true_params = draws_stacked["references"][0],
) which also required users to know the deeply hidden function f = bf.diagnostics.plots.pairs_posterior(
post_draws, val_sims,
dataset_id=0,
) So the interface of Tomorrow, I will work on the renamining. Here is the summary of what I propose to rename, must of which we discussed already:
You can check all the current diagnostics at work in the updated linear regression notebook on this branch. I would love to hear your thoughts and comments :-) |
This PR is now ready for review. It closes #307, #308, and #309. @stefanradev93 would you mind taking a look and merging if you are happy? I left some remaining ToDos in the code, which would further improve the plots but are not essential at the moment. I will take care of them at a later point. |
by setting linewidth to 0
change method and number of steps to account for CPU users
Made some adjustments with feedback from @paul-buerkner. IMO, the notebook looks great. Ready to merge from my side @stefanradev93. |
This PR addresses #309 by making the linear regression notebook the quickstart notebook and removing the current WIP quickstart notebook.
If few things we need to do before this can be merged: